Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename @adobe/generator-aio-console to @adobe/aio-cli-lib-console #167

Merged
merged 9 commits into from
Oct 6, 2021
Merged

rename @adobe/generator-aio-console to @adobe/aio-cli-lib-console #167

merged 9 commits into from
Oct 6, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 29, 2021 •
edited
Loading

Dependencies

  • update adobe/aio-lib-cli-console to final released version
  • update adobe/aio-lib-ims to final released version

Before merge

  • update Dependencies (see above)
  • do one final next tag release
  • revert package.json version to master branch package.json version

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #167 (96b3147) into master (a685c62) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          353       353           
  Branches        39        39           
=========================================
  Hits           353       353
Impacted Files Coverage Δ
src/commands/console/index.js 100.00% <100.00%> (ø)
src/commands/console/workspace/download.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a685c62...96b3147. Read the comment docs.

@shazron shazron mentioned this pull request Sep 29, 2021
Closed
@shazron shazron mentioned this pull request Sep 30, 2021
Merged
15 tasks
@shazron shazron closed this Oct 6, 2021
@shazron shazron reopened this Oct 6, 2021
@shazron shazron marked this pull request as ready for review October 6, 2021 04:19
@shazron
Copy link
Member Author

shazron commented Oct 6, 2021

Do not merge until Dependencies section is complete and tests pass after.

moritzraho
moritzraho approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks !

@shazron shazron merged commit 00e92fb into master Oct 6, 2021
@shazron shazron deleted the branch-prerelease branch October 6, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzraho moritzraho moritzraho approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@Himavanth Himavanth Awaiting requested review from Himavanth

@sandeep-paliwal sandeep-paliwal Awaiting requested review from sandeep-paliwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shazron @moritzraho